-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical operators #19
Comments
I think that this was required to be handled in 'iVis-at-Bilkent/sbgnviz.js#79'. However, I realized that previosuly multimers were not regarded as EPN's by mistake. I have fixed it now. I infer by the issue above that 'unspecified entity', 'simple chemical', 'macromolecule', 'nucleic acid feature', 'complex' and their multimers are EPN's. Is there any problem with my isEPN check. And is there still something wrong about this issue? |
My concern is about whether the targets of logic arcs can be logic operators or not. Currently, we can't define an operation such as (a AND b) OR ( c OR d) with an edge between AND and OR operators. |
The original issue iVis-at-Bilkent/sbgnviz.js#79 was missing the fact that a logical arc can be between two logical operators, not just between an EPN and a logical operator. Let's please add this as a valid interaction. |
I added the missing valid interaction. |
From @fdurupinar on June 21, 2016 20:46
Targets of logical arcs should be allowed to be logical operators.
From the current sbgn specs:
Origin: Any EPN (Section 2.4) or logical operator (Section 2.10).
Target: Any logical operator (Section 2.10).
Copied from original issue: iVis-at-Bilkent/sbgnviz.js#146
The text was updated successfully, but these errors were encountered: