Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to omit documentation at install #28

Closed
ivmai opened this issue Aug 2, 2017 · 12 comments
Closed

Option to omit documentation at install #28

ivmai opened this issue Aug 2, 2017 · 12 comments

Comments

@ivmai
Copy link
Owner

ivmai commented Aug 2, 2017

Reported by @concatime (#27) : could you provide an option to install only shared libraries like here, it would be really useful for a lot of us.

@ivmai
Copy link
Owner Author

ivmai commented Aug 2, 2017

To @concatime: Could you please be more verbose: which configure option(s) do you need? you need to omit .h and doc files installation, right?

@concatime
Copy link

concatime commented Aug 2, 2017

Well, for my script which install nginx and components, When It's time to install libatomic_ops, I need headers (with pkgconfig) and shared libraries since nginx use your awesome library. Like you see it here, it's a lot easier than manually copying file like here. Think about it, do I really need docs if I'm only using it as a part of something else ? Or easier since your library is not as big as jemalloc, offer us an option in ./configure like --no-docs. Don't omit .h files since nginx requires them.

@ivmai
Copy link
Owner Author

ivmai commented Aug 3, 2017

Ok, I will add "--disable-docs" to configure.

@concatime
Copy link

Awesome!

@ivmai ivmai changed the title Option to install only shared libraries Option to omit documentation at install Aug 3, 2017
ivmai added a commit that referenced this issue Aug 3, 2017
Issue #28 (libatomic_ops).

* Makefile.am (dist_doc_DATA): Define only if ENABLE_DOCS.
* doc/Makefile.am (dist_doc_DATA): Likewise.
* configure.ac (docs): New AC_ARG_ENABLE.
* configure.ac (ENABLE_DOCS): New AM_CONDITIONAL.
@ivmai
Copy link
Owner Author

ivmai commented Aug 3, 2017

Now it should work for you. Please test.

@ivmai ivmai closed this as completed Aug 3, 2017
@concatime
Copy link

I'm lost. There is no configure file.

@concatime
Copy link

concatime commented Aug 3, 2017

Well, looking into Travis, I was able to reproduce the steps. So, it seems to work perfectly.
The only thing that I would modify (and it's up to you), is the symlink:

libatomic_ops.so -> libatomic_ops.so.1.1.1
libatomic_ops.so.1 -> libatomic_ops.so.1.1.1

It would be better for reading if it was like this: libatomic_ops.so -> libatomic_ops.so.1; for a global result:
libatomic_ops.so -> libatomic_ops.so.1 -> libatomic_ops.so.1.1.1 (for libatomic_ops_gpl too).

@concatime
Copy link

concatime commented Aug 3, 2017

Thus, /usr/lib/libreadline.so.3 is a fully-qualified soname, which ldconfig would set to be a symbolic link to some realname like /usr/lib/libreadline.so.3.0. There should also be a linker name, /usr/lib/libreadline.so which could be a symbolic link referring to /usr/lib/libreadline.so.3.

Source.

@concatime
Copy link

concatime commented Aug 3, 2017

Then, if the name change to libatomic_ops.so.1.1.2 for example, you would then modify only ibatomic_ops.so.1, and not ibatomic_ops.so. This is why I have/had this line.

@ivmai
Copy link
Owner Author

ivmai commented Aug 7, 2017

It would be better for reading of it was like this: libatomic_ops.so -> libatomic_ops.so.1

I agree. But I think this is the behavior of libtool.

@concatime
Copy link

Oh, ok, not a real issue. I'm waiting for a release to add --disable-docs into my script. Thank you.

ivmai added a commit that referenced this issue Sep 20, 2017
Issue #28 (libatomic_ops).

* Makefile.am (dist_doc_DATA): Define only if ENABLE_DOCS.
* doc/Makefile.am (dist_doc_DATA): Likewise.
* configure.ac (docs): New AC_ARG_ENABLE.
* configure.ac (ENABLE_DOCS): New AM_CONDITIONAL.
@ivmai
Copy link
Owner Author

ivmai commented Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants