Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data link #52 #54

Closed
wants to merge 7 commits into from
Closed

Data link #52 #54

wants to merge 7 commits into from

Conversation

Bonnarel
Copy link
Contributor

This PR is proposed by Laurent and me. It introduces the description of the templating mechanism in service descriptor accessURL. It's related to issue #27. takes into account the recent Running meetings discussions

@mbtaylor
Copy link
Member

mbtaylor commented Dec 8, 2020

"A templating mechanism is proposed" - this is not appropriate language for a standard. The text needs to specify in this and the preceding section that the accessURL value is a templated URL that must be interpreted according to RFC6570 (otherwise clients that don't do that will understand the wrong URLs for services that do specify templated URLs).

You can't use the "Fields:" prefix for namespacing, since it violates the RFC6570 syntax for variable naming (see the varspec production in RFC6750 section 2.3). For simplicity I would be in favour of just not namespacing here, on the grounds that the PARAM and FIELD names ought not to share any of the same names (either enforce that with a MUST or just note undefined behaviour in case that a variable name refers to both a FIELD and a PARAM in the same context).

Third example: the referenced fields are

<FIELD ID="RAJ2000" name="RAJ2000"  datatype="double" arraysize="1"/>
<FIELD ID="DEJ2000" name="DEJ2000"  datatype="double" arraysize="1"/>

and referenced as "{Fields:RAJ2000}{Fields:DEJ2000}". Thus it's not clear from the example whether the reference is to the name or ID attribute. Remove or rename the non-referenced attributes to clarify what's going on here. From the other example it looks like the name attribute is what's being referenced, but that is not explicitly written, please add some text to this effect. I suggest also adding some text that makes clear what the RFC6570 syntax restrictions are on substitution variable names (RFC 6570 section 2.3): essentially alphanumerics, period, underscore, and percent-encoded characters.

Note also that arraysize="1" should be removed from these FIELD elements, deprecated since VOTable 1.3 Erratum 3 (and also in VOTable 1.4).

The template "-c={Fields:RAJ2000}{Fields:DEJ2000}" is reported as expanding to "-c=250.456+27.863". Where does the "+" character come from in that expansion?

Bonnarel and others added 5 commits December 9, 2020 19:23
changes suggested by Mark Taylor
fix encoding % mistake in templating example
Changing Fields: in Fields. in URL templating examples
@pdowler
Copy link
Collaborator

pdowler commented Nov 3, 2021

Is it OK if we close this PR and start fresh after DataLink-1.1? I am pretty sure, at a minimum, the conflicts will be tough to manage without losing other work.

@Bonnarel
Copy link
Contributor Author

Bonnarel commented Nov 3, 2021

OK with me for that

@Bonnarel
Copy link
Contributor Author

Bonnarel commented Nov 3, 2021

Laurent ?

@pdowler
Copy link
Collaborator

pdowler commented Nov 16, 2021

closed this because it is now significantly out of date and issue deferred to 1.2

@pdowler pdowler closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants