Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending DataLink scope #9

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Conversation

Bonnarel
Copy link
Contributor

No description provided.


\subsubsection{Metadata and data related to provenance entities}

The IVOA Provenance datamodel \citep{pr:provdm} represents metadata tracing the history of data. This information can be retrieved through ProvTAP \citep{iwd:provtap} or ProvSAP \citep{iwd:provsap} DAL services. The Entity instances represent the state of the data items between various steps of the data processing flow. “Entities” can be hooked to lists of real datasets retrieval and previews, or Obscore, SimDM and SSA metadata describing them using the \blinks endpoint.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this PR relates to #10, since it requests the same change here. To make sure that this doesn't get lost, copying my comment from there:

This is true only for DatasetEntity objects in Provenance. However there are also ValueEntity objects (f.e. to configuration parameters, as in the MuseWISE implementation) which cannot be hooked to lists of real datasets retrieval and previews. IMO this should be limited to DatasetEntity instances.

Suggested change
The IVOA Provenance datamodel \citep{pr:provdm} represents metadata tracing the history of data. This information can be retrieved through ProvTAP \citep{iwd:provtap} or ProvSAP \citep{iwd:provsap} DAL services. The Entity instances represent the state of the data items between various steps of the data processing flow. “Entities” can be hooked to lists of real datasets retrieval and previews, or Obscore, SimDM and SSA metadata describing them using the \blinks endpoint.
The IVOA Provenance datamodel \citep{pr:provdm} represents metadata tracing the history of data. This information can be retrieved through ProvTAP \citep{iwd:provtap} or ProvSAP \citep{iwd:provsap} DAL services. The Entity instances represent the state of the data items between various steps of the data processing flow. “DatasetEntities” can be hooked to lists of real datasets retrieval and previews, or Obscore, SimDM and SSA metadata describing them using the \blinks endpoint.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best way to avoid conflict with other standards is to not restate things from that spec with too much detail.

However, in this case I cannot tell if this advice is aimed at (i) linking from a dataset to one or more services that provide the provenance metadata or (ii) using datalink in a provenance service response to link to datasets. Sounds more like the latter, in which case either accept Ole's change or simplify the text a little to be less specific.

@@ -66,16 +66,18 @@ \section*{Conformance-related definitions}
\section{Introduction}

This specification defines mechanisms for connecting metadata about
discovered datasets to the data, related data products, and web services
that can act upon the data.
discovered VO items to related data products, and web services
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we need to broaden beyond datasets, but "VO items" is odd. Maybe instead of "metadata about discovered VO items to..." we should say "metadata discovered via one service to...".
Plus, the comma after products should be removed.


\subsubsection{Metadata and data related to provenance entities}

The IVOA Provenance datamodel \citep{pr:provdm} represents metadata tracing the history of data. This information can be retrieved through ProvTAP \citep{iwd:provtap} or ProvSAP \citep{iwd:provsap} DAL services. The Entity instances represent the state of the data items between various steps of the data processing flow. “Entities” can be hooked to lists of real datasets retrieval and previews, or Obscore, SimDM and SSA metadata describing them using the \blinks endpoint.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best way to avoid conflict with other standards is to not restate things from that spec with too much detail.

However, in this case I cannot tell if this advice is aimed at (i) linking from a dataset to one or more services that provide the provenance metadata or (ii) using datalink in a provenance service response to link to datasets. Sounds more like the latter, in which case either accept Ole's change or simplify the text a little to be less specific.

@pdowler pdowler merged commit cfed401 into ivoa-std:master Nov 17, 2019
@Bonnarel
Copy link
Contributor Author

Bonnarel commented Nov 26, 2019 via email

@Bonnarel
Copy link
Contributor Author

Bonnarel commented Nov 26, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants