-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropout function for MindSpore Frontend #21362
Conversation
Thanks for contributing to Ivy! 😊👏 |
Hi @kurshakuz Please review this PR. I will be highly thankful! 🙏 |
Hi @kurshakuz Just a gentle request to please review this PR. I will be extremely thankful 🙏 |
Hi @kurshakuz I have resolved the Lint Issues as well. Can you please check, and merge if it looks good? Thanks. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you please resolve the conflict and I will merge it
@kurshakuz I have resolved the conflicts. Can you please merge this PR? Thanks! :) |
Hi @kurshakuz Just a gentle reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @savita921
Thank you so much for the PR. Not sure why this wasn't merged earlier. Apologies on our end.
I will merge this by end of today. Thank you very much for the contribution :)
close #21361
As with other MindSpore Frontend Functions, I have kept the test commented as the MindSpore Backend has not added yet. I have tested the Logic manually and it works fine.