Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropout function for MindSpore Frontend #21362

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

savita921
Copy link
Contributor

close #21361

As with other MindSpore Frontend Functions, I have kept the test commented as the MindSpore Backend has not added yet. I have tested the Logic manually and it works fine.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@farhan-ali9 farhan-ali9 mentioned this pull request Aug 6, 2023
@savita921
Copy link
Contributor Author

Hi @kurshakuz Please review this PR. I will be highly thankful! 🙏

@savita921
Copy link
Contributor Author

Hi @kurshakuz Just a gentle request to please review this PR. I will be extremely thankful 🙏

@savita921
Copy link
Contributor Author

Hi @kurshakuz I have resolved the Lint Issues as well. Can you please check, and merge if it looks good? Thanks. :)

Copy link
Contributor

@kurshakuz kurshakuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you please resolve the conflict and I will merge it

@savita921
Copy link
Contributor Author

@kurshakuz I have resolved the conflicts. Can you please merge this PR? Thanks! :)

@savita921
Copy link
Contributor Author

Hi @kurshakuz Just a gentle reminder

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @savita921
Thank you so much for the PR. Not sure why this wasn't merged earlier. Apologies on our end.
I will merge this by end of today. Thank you very much for the contribution :)

@Ishticode Ishticode merged commit ad0ae6c into ivy-llc:main Feb 29, 2024
115 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropout
4 participants