Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrcoef #21964

Closed
wants to merge 1 commit into from
Closed

corrcoef #21964

wants to merge 1 commit into from

Conversation

hn-on-fire
Copy link

@hn-on-fire hn-on-fire commented Aug 15, 2023

closes #10704

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PaddlePaddle Backend Developing the Paddle Paddle Backend. label Aug 15, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@illia-bab
Copy link
Contributor

Hey @hn-on-fire , thanks for PR!
You should create your own issue to this PR as explained here: https://unify.ai/docs/ivy/overview/contributing/open_tasks.html#creating-an-issue-on-ivy-s-github-using-a-template. After creating your own issue link it to the PR with message: "Close #issue_number".
Your PR doesn't pass "Check formatting" test, this may help: https://unify.ai/docs/ivy/overview/contributing/setting_up.html#pre-commit.
You shouldn't remove y argument from function's signature, because it should be appropriately handled. The reason for this is explained here: https://unify.ai/docs/ivy/overview/deep_dive/superset_behaviour.html#superset-behaviour.
Good luck!

@illia-bab illia-bab self-requested a review August 16, 2023 10:24
Copy link
Contributor

@illia-bab illia-bab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes needed are explained in the previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PaddlePaddle Backend Developing the Paddle Paddle Backend. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Statistical Functions to Paddle Backend
7 participants