Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: show welcome message always #23592

Merged
merged 1 commit into from
Sep 14, 2023
Merged

ci: show welcome message always #23592

merged 1 commit into from
Sep 14, 2023

Conversation

a0m0rajab
Copy link
Contributor

@a0m0rajab a0m0rajab commented Sep 14, 2023

PR Description

This PR improves the welcome message that we have and show it even if we have failing semantic PR.

Related Issue

Close #23589

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials:

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@a0m0rajab a0m0rajab merged commit 5b48641 into main Sep 14, 2023
138 of 141 checks passed
@a0m0rajab a0m0rajab deleted the ci-improve-welcome-message branch September 14, 2023 09:51
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dx: welcome message is not showing
1 participant