Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete operation #22

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Add delete operation #22

merged 3 commits into from
Mar 24, 2019

Conversation

iwanbk
Copy link
Owner

@iwanbk iwanbk commented Mar 22, 2019

Fixes #20

@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #22 into master will increase coverage by 1.65%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   84.61%   86.26%   +1.65%     
==========================================
  Files           7        7              
  Lines         260      284      +24     
==========================================
+ Hits          220      245      +25     
+ Misses         22       21       -1     
  Partials       18       18
Impacted Files Coverage Δ
message.go 94.59% <100%> (+0.84%) ⬆️
bcache.go 86.48% <100%> (+0.37%) ⬆️
peer.go 82.71% <90.47%> (+5.68%) ⬆️
cache.go 91.3% <91.3%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d5dde...e39bfc5. Read the comment docs.

@iwanbk iwanbk changed the title WIP: Add delete operation Add delete operation Mar 24, 2019
@iwanbk iwanbk merged commit 7eebcef into master Mar 24, 2019
@iwanbk iwanbk deleted the delete branch March 24, 2019 15:13
@luisdavim
Copy link

Hi, if I understand correctly, you're not actually removing the keys from the cache, just marking them as deleted.

@iwanbk
Copy link
Owner Author

iwanbk commented Mar 24, 2019

Hi, if I understand correctly, you're not actually removing the keys from the cache, just marking them as deleted.

Hi, you're correct, see #23 for the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants