Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated function with PHP 8.2 & 8.3 #13

Closed
iworks opened this issue Nov 29, 2023 · 1 comment
Closed

Deprecated function with PHP 8.2 & 8.3 #13

iworks opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@iworks
Copy link
Owner

iworks commented Nov 29, 2023

https://wordpress.org/support/topic/deprecated-function-with-php-8-2-8-3/

Hello,

I shall let you know that current version of your plugin uses at least one deprecated function in PHP 8.2 and 8.3.

Visiting plugins page (/wp-admin/plugins.php) with WP Query Monitor extension enabled, shows the following error:

Deprecated Message:

ltrim(): Passing null to parameter #1 ($string) of type string is deprecated

Location: wp-includes/formatting.php:4494 ltrim() wp-includes/formatting.php:4494esc_url() 
wp-content/plugins/og/includes/iworks/rate/rate.php:119
iworks_rate->add_donate_link()
wp-includes/class-wp-hook.php:324
apply_filters('plugin_action_links_og/og.php')
wp-admin/includes/class-wp-plugins-list-table.php:985
WP_Plugins_List_Table->single_row()
wp-admin/includes/class-wp-plugins-list-table.php:706
WP_Plugins_List_Table->display_rows()
wp-admin/includes/class-wp-list-table.php:1709
WP_List_Table->display_rows_or_placeholder()
wp-admin/includes/class-wp-list-table.php:1636
WP_List_Table->display()
wp-admin/plugins.php:796

In order to avoid getting such error, and to prepare for future PHP versions, it would be a great thing to adapt the code in order to fit newer PHP versions.

Best regards

@iworks iworks self-assigned this Nov 29, 2023
@iworks iworks added the bug Something isn't working label Nov 29, 2023
iworks added a commit that referenced this issue Dec 1, 2023
fixing Deprecated function with PHP 8.2 & 8.3 #13
#13
@iworks
Copy link
Owner Author

iworks commented Dec 1, 2023

should be fixed, please update and re-test

@iworks iworks closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant