4.0 Refactoring useFieldState args, onValidSubmit, and isFormBusy #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanb
commented
Mar 3, 2024
Comment on lines
-35
to
-36
| it('should setup validation form and not report any errors if form is valid', async () => { | ||
| render(<SampleFieldWithRenderError />, { wrapper: FullyControlledFieldWrapper }) |
There was a problem hiding this comment.
These were more like integration tests. bleh... Mocked out the field manager, tested only the behavior of the FieldManagerForm itself.
nathanb
force-pushed
the
more-cleanup
branch
4 times, most recently
from
116e064
to
25a2fed
Compare
…d state props for isFormBusy, toggleFormBusy for managing custom styling/DOM state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fields, options)onValidSubmitfromuseFieldStateto onlyFieldManager&ControlledFieldManager. (It's still on `ValidatedForm, but does not provide the field values).isFormBusyandtoggleFormBusy(state?: boolean)as a helper for DOM/styling during async submit handling.