-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to bun #61
Conversation
🦋 Changeset detectedLatest commit: 0573073 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
as alternative to "pnpm recursive exec -- pnpm version 0.1.0", a reset-versions.ts script can be executed
@ixahmedxi - Should we remove Volta from Orbitkit, as bun isn't currently supported? |
@imCorfitz Yes that is correct, with the usage of bun, we shouldn't need volta at all. |
Regarding the commitlint scopes, we got two options:
What do we prefer? |
added custom scopes script for commitlint
reverting mistake in commands
It looks all good to me, just one lil thing left to do which is to add a changeset to the PR. Also don't forget to update the version in the root |
Would you consider this a patch or minor version update? |
@imCorfitz I think it's a minor |
With the eslint v9 stuff coming in, would make sense to start a 0.2 version upgrade |
That's what I thought.. Will update the changesets quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it 🚀
Thanks to the version 1.1.9 release of Bun, a lot of workspace issues have been resolved, and we are now one step closer to getting bun for Orbitkit.
Fixes #50
To install a dependency to a specific package use
--cwd
e.g.:bun add --cwd apps/web sharp
To do:
pnpm recursive exec -- pnpm version 0.1.0