Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to bun #61

Merged
merged 20 commits into from
May 27, 2024
Merged

feat: upgrade to bun #61

merged 20 commits into from
May 27, 2024

Conversation

imCorfitz
Copy link
Collaborator

@imCorfitz imCorfitz commented May 22, 2024

Thanks to the version 1.1.9 release of Bun, a lot of workspace issues have been resolved, and we are now one step closer to getting bun for Orbitkit.

Fixes #50

To install a dependency to a specific package use --cwd e.g.: bun add --cwd apps/web sharp

To do:

  • Update CONTRIBUTING.md
  • Update Documentation
  • Update Github Workflows
  • Update Playwright configs
  • Update Husky
  • Find alternative to @commitlint/config-pnpm-scopes
  • Create alternative to pnpm recursive exec -- pnpm version 0.1.0
  • Remove Volta

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: 0573073

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@orbitkit/marketing Minor
@orbitkit/storybook Minor
@orbitkit/tailwind Minor
@orbitkit/tsconfig Minor
eslint-config-orbitkit Minor
@orbitkit/vite Minor
@orbitkit/assets Minor
@orbitkit/utils Minor
@orbitkit/auth Minor
@orbitkit/core Minor
@orbitkit/api Minor
@orbitkit/env Minor
@orbitkit/db Minor
@orbitkit/ui Minor
@orbitkit/docs Minor
@orbitkit/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imCorfitz
Copy link
Collaborator Author

imCorfitz commented May 24, 2024

@ixahmedxi - Should we remove Volta from Orbitkit, as bun isn't currently supported?

@ixahmedxi
Copy link
Owner

@imCorfitz Yes that is correct, with the usage of bun, we shouldn't need volta at all.

@imCorfitz
Copy link
Collaborator Author

imCorfitz commented May 25, 2024

Regarding the commitlint scopes, we got two options:

  1. Remove the package: Allowing any scope to be written when committing changes.
  2. Write a proprietary getProjects function in a .commitlintrc file.

What do we prefer?

added custom scopes script for commitlint
@imCorfitz imCorfitz marked this pull request as ready for review May 27, 2024 13:19
reverting mistake in commands
@ixahmedxi
Copy link
Owner

It looks all good to me, just one lil thing left to do which is to add a changeset to the PR. Also don't forget to update the version in the root package.json because changeset doesn't do that automatically

@imCorfitz
Copy link
Collaborator Author

Would you consider this a patch or minor version update?

@ixahmedxi
Copy link
Owner

@imCorfitz I think it's a minor

@ixahmedxi
Copy link
Owner

With the eslint v9 stuff coming in, would make sense to start a 0.2 version upgrade

@imCorfitz
Copy link
Collaborator Author

That's what I thought.. Will update the changesets quickly.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Owner

@ixahmedxi ixahmedxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it 🚀

@ixahmedxi ixahmedxi merged commit 375aee3 into ixahmedxi:main May 27, 2024
4 of 5 checks passed
@imCorfitz imCorfitz deleted the feat/bun branch May 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun support?
2 participants