WIP: Make the quick access filter more flexible #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format right now is: <res1[,res2,res3]>\s<name1[,name2,name3]> where 'name' can be: - `*` - `<name>` - `<namemspace>/*` - `<namespace>/<name>` The idea is to keep this (simple) format but allow multiple ;-separated filters: <filter1>[;<filter2>;<filter3>] This PR has a PoC, but I'm not sure it's the most efficient implementation, and the UI performance should remain fast enough. Plus, adding some tests would be great.
iximiuz
force-pushed
the
quick-access-filter-ng
branch
from
510e1d0
to
897b8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format right now is:
<res1[,res2,res3]>\s<name1[,name2,name3]>
where 'name' can be:
*<name><namemspace>/*<namespace>/<name>The idea is to keep this (simple) format but allow multiple ;-separated filters:
This PR has a PoC, but I'm not sure it's the most efficient implementation, and the UI performance should remain fast enough. Plus, adding some tests would be great.