Added levels to DFDs #132
Merged
Added levels to DFDs #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I wonder if this should be done by layering multiple models over each other. It would imply that each layer should be a valid model on its own.
Isn't it currently possible to draw the DFD in a way it's missing crucial information to understand the model?
Anyway, this PR is missing tests that would document the use cases for this feature.
|
Will do!
…On Sun, Oct 18, 2020, 13:32 Jan Waś ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pytm/pytm.py
<#132 (comment)>:
> @@ -838,6 +862,9 @@ class Element:
doc="Maximum data classification this element can handle.",
)
findings = varFindings([])
+ levels = [
An important rationale is to be consistent with other attributes. Levels
are not special. You could use varData as an example, just with int
instead of Data and a regular set at the end instead of Dataset
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#132 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2BAPPZ477B7OYGFGXK3DSLMRCHANCNFSM4ST2LMFQ>
.
|
|
Ah. I think i get what you're saying. Let me rethink it.
…On Sun, Oct 18, 2020, 13:26 Jan Waś ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pytm/pytm.py
<#132 (comment)>:
> @@ -404,6 +404,18 @@ def _get_elements_and_boundaries(flows):
return (list(elements), list(boundaries))
+def _render_by_level(level):
+ # Level 0 (default) always renders
+ if TM._levels == [0]:
But it's only one level
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#132 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2BAILJZZP5B5GI5B22EDSLMQNJANCNFSM4ST2LMFQ>
.
|
izar
force-pushed
the
manyLevelsModels
branch
from
71f6f2e
to
4af7b79
Compare
| @@ -838,6 +862,7 @@ class Element: | |||
| doc="Maximum data classification this element can handle.", | |||
| ) | |||
| findings = varFindings([]) | |||
| levels = varInts({0}) | |||
There was a problem hiding this comment.
One last request - this needs a doc, can you add it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is and idea to be able to add to the same model, for example, infra-structure and application layers, then select on which diagram to produce. This only impacts DFDs, threat elicitation, sequence diagrams and reporting stay the same.