Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require postgrex and jason only for dev and test #70

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Require postgrex and jason only for dev and test #70

merged 2 commits into from
Feb 26, 2020

Conversation

ggpasqualino
Copy link
Contributor

@ggpasqualino ggpasqualino commented Feb 26, 2020

Postgres seems to be used only in these environments, so we can reduce its scope to avoid polluting the client applications that use a different database.
Jason also seems to be used only for testing, db driver libraries have their own json configuration.

The library is only necessary for these environments, so we can reduce
its scope to avoid polluting the client applications.
@ggpasqualino ggpasqualino changed the title Require postgrex only for dev and test Require postgrex and jason only for dev and test Feb 26, 2020
@izelnakri izelnakri merged commit 6b9ad0c into izelnakri:master Feb 26, 2020
@izelnakri
Copy link
Owner

Thank you @ggpasqualino, cutting a release now

@ggpasqualino
Copy link
Contributor Author

Awesome @izelnakri! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants