Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enablement of round brackets enables all but angle brackets #31

Closed
Alexsey opened this issue Feb 26, 2018 · 5 comments
Closed

Enablement of round brackets enables all but angle brackets #31

Alexsey opened this issue Feb 26, 2018 · 5 comments
Labels
bug?

Comments

@Alexsey
Copy link
Contributor

Alexsey commented Feb 26, 2018

STR

  1. Disable all brackets but round
    settings
  2. Look at some code with different types of brackets
    code

Expected Behavior

Only round brackets should be colored

Current Behavior

All but angle brackets are colored

  • Plugin version: 5.0.0-RC2
  • IDEA version: WebStorm 2017.3.4
  • Operating System and version: Windows 10
@Alexsey Alexsey changed the title Enablement of round brackets enables all but angel brackets Enablement of round brackets enables all but angle brackets Feb 26, 2018
@Alexsey
Copy link
Contributor Author

Alexsey commented Feb 26, 2018 •
edited
Loading

BTW after enabling of other brackets, colors get changed:
settings
become
code

@izhangzhihao
Copy link
Owner

Related to this line, for example: if we disable rainbow for square brackets, we should not give them defaultRoundBracketsColors

@izhangzhihao
Copy link
Owner

screen shot 2018-02-27 at 9 51 07 am

@izhangzhihao
Copy link
Owner

Please try this snapshot build
intellij-rainbow-brackets.jar.zip

@izhangzhihao
Copy link
Owner

See this PR

YiiGuxing added a commit that referenced this issue Feb 27, 2018
@YiiGuxing
Merge pull request #33 from izhangzhihao/Issue31-fix
23bd61f 
Fix #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexsey @izhangzhihao