Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Улучшение визуализации замеров #100 #101

Merged
merged 7 commits into from
Nov 25, 2019

Conversation

izvolov
Copy link
Owner

@izvolov izvolov commented Nov 22, 2019

No description provided.

@izvolov izvolov self-assigned this Nov 22, 2019
@izvolov izvolov requested a review from bagobor November 22, 2019 20:11
Comment on lines +36 to +39
plt.title(u'Сортировка целых чисел (' + integer_type + ')', size=14)
plt.xlabel(u'Количество элементов в массиве, шт', size=10)
plt.ylabel(u'Среднее время сортировки, с', size=10)
plt.grid(True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо не забыть это тоже перевести )

Comment on lines +31 to +34
plt.title(u'Доступ к элементам контейнеров размера ' + str(array_size), size=14)
plt.xlabel(u'Показатель разброса, ед', size=10)
plt.ylabel(u'Среднее время доступа, с', size=10)
plt.grid(True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

наконец добавили малтилайн комменты на гитхабе. ура. )

Copy link

@bagobor bagobor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plt.legend(loc='lower left')
plt.tight_layout()
plt.savefig(file_name, format='png')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может выложишь и результат тоже? будет наглядней и можно в включить в документацию.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, хорошая идея, надо добавить. Только, наверное, нужно сделать описание к методике замеров, потому что она не совсем очевидная. Подумаю.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исходники тестов вполне себе описание.

@izvolov izvolov merged commit 76664b0 into master Nov 25, 2019
@izvolov izvolov deleted the benchmark-visualization-#100 branch November 25, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants