This repository has been archived by the owner on Mar 25, 2020. It is now read-only.
Added a way to move roles #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 3, 2017 05:12
added the moveRoles function, which takes a roleId and a relative position. The relative position is an integer that represents how many roles you want to move up or down.
Hopefully this will not break anything but it is required for the previous commit. Arrays are also seen as JSON for web requests, and content type should also be "application/json"
Changing the type(data) calls to typeof(data) from the last commit, as requested by the repo owner.
typeof Array == 'object, so just removed the check for if it's an array or not.
|
Can we also add a way to implement a way to battle other trainers? If that is already a thing then can someone tell me how to do it? |
Woor
pushed a commit
to Woor/discord.io
that referenced
this pull request
Oct 30, 2017
Added a way to move roles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roles can now be moved, I am unsure if the second commit will break anything but I skimmed through every usage of _req and APIRequest and it doesn't seem like arrays are ever sent as data again so i went ahead and added arrays as JSON.