Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-tools.nvim messages are stale #171

Closed
j-hui opened this issue Nov 23, 2023 · 1 comment
Closed

haskell-tools.nvim messages are stale #171

j-hui opened this issue Nov 23, 2023 · 1 comment
Labels
bug Something isn't working highlight Related to highlighting

Comments

@j-hui
Copy link
Owner

j-hui commented Nov 23, 2023

image

I set this up with haskell-tools.nvim

Also, separate issue: highlighting is different after the last line

@j-hui j-hui added bug Something isn't working highlight Related to highlighting labels Nov 23, 2023
@gegoune
Copy link

gegoune commented Nov 24, 2023

Different highlighting might be caused by same issue as #32, if you happened to have some non-empty lines half way up your notifications stack.

@j-hui j-hui changed the title HLS messages are stale haskell-tools.nvim messages are stale Nov 28, 2023
@j-hui j-hui closed this as completed in fe60ce7 Nov 28, 2023
j-hui added a commit that referenced this issue Dec 6, 2023
This feature was originally introduced to address #171, where empty
messages happened to correlate with stale messages. I made it true by
default for nicer behavior out of the box, but that was the wrong choice
for three reasons:

(1)     It turns out HLS only exhibits that behavior when configured by
        haskell-tools.nvim on nvim < v0.9.4; the issue goes away on nvim
        nightly (i.e., what will become v0.10.*).

(2)     It is not always true that empty message => stale message.
        I don't know why I assumed that would be the case, and in fact
        it is perfectly reasonable for a progress notification to carry
        no message and convey everything it needs to convey in the
        title.

(3)     With ignore_empty_message = true, the plugin favors _not_
        showing valid notifications over showing invalid notifications.
        In my opinion, the former is a worse failure mode because it is
        less noticeable and also more annoying to debug (you would need
        to opt into logging, rather than being able to tell directly
        from the notifications themselves).

Thus, to make sure issues like #176 don't crop up again without an
obvious diagnosis, I'm changing the default behavior. If the user wants
to opt into ignoring empty messages, they can still override this
setting's default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working highlight Related to highlighting
Projects
None yet
Development

No branches or pull requests

2 participants