Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of wrap_in #262

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Add support of wrap_in #262

merged 2 commits into from
Jun 1, 2021

Conversation

Kdecherf
Copy link
Collaborator

@Kdecherf Kdecherf commented May 22, 2021

Fixes #180

Tests are missing for now Tests added, ready for review

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@coveralls
Copy link

coveralls commented May 22, 2021

Coverage Status

Coverage decreased (-0.2%) to 96.264% when pulling 2aea19f on Kdecherf:feature/wrap_in into 9e6e54d on j0k3r:master.

@Kdecherf Kdecherf force-pushed the feature/wrap_in branch 3 times, most recently from 7cd1662 to 3465b51 Compare May 23, 2021 17:15
Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, you finally did it 👏

src/Extractor/ContentExtractor.php Outdated Show resolved Hide resolved
Fixes j0k3r#180

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, thanks 🤝

@j0k3r j0k3r merged commit b5c5129 into j0k3r:master Jun 1, 2021
@Kdecherf Kdecherf deleted the feature/wrap_in branch June 1, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for wrap_in
3 participants