Convert configuration to Value Object #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, that looks about right. Once we bump to PHP 8, we will even be able to switch to named parameters and ditch options resolver altogether. And then with |
Mostly to enforce type of each parameter of a config. Also, enforce type for the input configuration using `setAllowedTypes`.
Remove public method `getConfig` (which was only used internally)
j0k3r
force-pushed
the
feature/config-as-value-object
branch
from
789d220
to
84a3cec
Compare
|
I think I'm done @jtojnar, can you take a look? 🙏 |
jtojnar
reviewed
Jan 27, 2022
jtojnar
reviewed
Jan 27, 2022
jtojnar
reviewed
Jan 27, 2022
| * @param array $config | ||
| */ | ||
| public function __construct($config = [], LoggerInterface $logger = null) | ||
| public function __construct(array $config = [], LoggerInterface $logger = null) |
There was a problem hiding this comment.
Maybe we could even require the objects instead of arrays to be passed to constructors.
There was a problem hiding this comment.
I agree it could allow to better check for sub-configuration but I found it more verbose. You'll have to use object config for each level. I think it'll add complexity where array is really simple to use.
jtojnar
reviewed
Jan 27, 2022
Comment on lines
+27
to
+28
| private array $http_client; | ||
| private array $extractor; |
There was a problem hiding this comment.
Then we might have objects here.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to enforce type of each parameter of a config.
Also, enforce type for the input configuration using
setAllowedTypes.See #283 (review)
Is it something like that you were talking about @jtojnar?