Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of referer from site config #64

Merged
merged 2 commits into from
Nov 14, 2016
Merged

Add support of referer from site config #64

merged 2 commits into from
Nov 14, 2016

Conversation

Kdecherf
Copy link
Collaborator

@Kdecherf Kdecherf commented Nov 9, 2016

Following #61, this PR adds the support of http_header(referer) property from site config.

Fixes #62

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 98.333% when pulling d0fc8e4 on Kdecherf:referer into 71fd754 on j0k3r:master.

@Kdecherf
HttpClient: add getReferer() to extract referer from site config
6c1d799 
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf
ConfigBuilder: add support of http_header(referer)
73de5ef 
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf changed the title [WIP] Add support of referer from site config Add support of referer from site config Nov 13, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.542% when pulling 73de5ef on Kdecherf:referer into 71fd754 on j0k3r:master.

@Kdecherf
Copy link
Collaborator Author

PR ready for review.

j0k3r
j0k3r approved these changes Nov 14, 2016
View reviewed changes
Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@j0k3r j0k3r merged commit 033c80e into j0k3r:master Nov 14, 2016
@Kdecherf Kdecherf deleted the referer branch November 14, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kdecherf @coveralls @j0k3r