-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multi-file support #9
Conversation
parsing will stop on the first invalid yml file
//cc @xgc1986 |
|
||
if ($argPath === '-') { | ||
|
||
$lintPath = function($path) use ($argQuiet, $appStr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just moved the already existing code into this closure to ease re-use (and dont define global symbols, like functions or similar)
Thanks for this @staabm. I'll take a closer look on the weekend. |
ping @j13k |
Apologies for the delay on this @staabm — my spare time is being taken up by another project at the moment. Before the next release of this tool, I want to take my time to create some tests (see issue #5) as the the number of installations has increased significantly since the current release. Having said that, I'll aim to at least review and merge your PR into |
@j13k ping |
1 similar comment
@j13k ping |
@j13k multi-file support would be really nice ;) please add it |
@staabm, as you can see, I have finally merged the PR! As I mentioned in a previous comment, I want to shore up the project with unit tests before the next stable release, but until then you can make use of multi-file support by installing the |
Thx! |
parsing will stop on the first invalid yml file.
closes #3
because of the re-indent of several lines at best review with whitespaces ignored:
https://github.com/j13k/yaml-lint/pull/9/files?w=1