Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-file support #9

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Added multi-file support #9

merged 3 commits into from
Nov 1, 2019

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 10, 2019

parsing will stop on the first invalid yml file.

  • remove note about not supporting multiple files from Readme

closes #3

because of the re-indent of several lines at best review with whitespaces ignored:
https://github.com/j13k/yaml-lint/pull/9/files?w=1

parsing will stop on the first invalid yml file
@staabm
Copy link
Contributor Author

staabm commented May 10, 2019

//cc @xgc1986


if ($argPath === '-') {

$lintPath = function($path) use ($argQuiet, $appStr) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just moved the already existing code into this closure to ease re-use (and dont define global symbols, like functions or similar)

@staabm
Copy link
Contributor Author

staabm commented May 10, 2019

tested several scenarios

grafik

@j13k
Copy link
Owner

j13k commented May 15, 2019

Thanks for this @staabm. I'll take a closer look on the weekend.

@staabm
Copy link
Contributor Author

staabm commented May 21, 2019

ping @j13k

@j13k
Copy link
Owner

j13k commented May 28, 2019

Apologies for the delay on this @staabm — my spare time is being taken up by another project at the moment.

Before the next release of this tool, I want to take my time to create some tests (see issue #5) as the the number of installations has increased significantly since the current release.

Having said that, I'll aim to at least review and merge your PR into master within the next few days.

@staabm
Copy link
Contributor Author

staabm commented Aug 14, 2019

@j13k ping

1 similar comment
@staabm
Copy link
Contributor Author

staabm commented Oct 2, 2019

@j13k ping

@bestit-dfuchs
Copy link

@j13k multi-file support would be really nice ;) please add it

@j13k j13k merged commit 190dbab into j13k:master Nov 1, 2019
@j13k
Copy link
Owner

j13k commented Nov 1, 2019

@staabm, as you can see, I have finally merged the PR!

As I mentioned in a previous comment, I want to shore up the project with unit tests before the next stable release, but until then you can make use of multi-file support by installing the dev-master version.

@staabm staabm deleted the multi-file branch November 1, 2019 08:23
@staabm
Copy link
Contributor Author

staabm commented Nov 1, 2019

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple input files and/or directories
3 participants