Updated building instructions for Linux #45
Conversation
…oper bazel version
There was a problem hiding this comment.
It's a very good idea to download bazel automatically to python venv imo, but I think there are several points that can be improved before we get this merged:
- macOS and Windows could also experience similar problems from using different bazel version, we could address this altogether by converting the download step to python script, and make it part of
setup.pywhile creating venv. - Since we are using pre-compiled bazel anyways, we could download bazelisk instead to automatically select required version for
mediapipesubmodule, as they could update required bazel version in the future.
How do you think about the improvements above?
|
Yeah sure converting to python script and integrating it into the setup process itself is indeed a very good idea. Just needed a small clarification how do you plan to handle the downloads?
|
Downloading through Python itself would be more suitable, so that we can maintain one code path for this task. |
|
Added auto-download of the latest bazelisk version to the Is there any need to update the |
docs/BUILDING.md
Outdated
| @@ -55,6 +55,8 @@ Run `build.py --help` to see all options. | |||
| 1. Install OpenCV and FFmpeg, then modify `mediapipe/third_party/opencv_linux.BUILD` to make OpenCV visible to Bazel. | |||
| 2. Run `build.py desktop` to build desktop library. | |||
|
|
|||
| NOTE:- Bazel version 6.1.1 is strictly required and is installed automatically by running the `setup.py`, it is installed inside the Python venv. | |||
There was a problem hiding this comment.
Nitpicking: No need to state required Bazel version explicitly if setup script has already handled for us, or we would need to update this section every time mediapipe change required version.
There was a problem hiding this comment.
Yeah, I was thinking about the need to handle this whenever mediapipe decides to update their version.
So.... I think I should just remove this whole line altogether
I prefer leaving it unchanged unless there are known issues or package deprecation. |
|
Thanks! |
* Updated building instructions for Linux and script for downloading proper bazel version * Added automatic download Bazelisk during setup process * Removed redundant information in BUILDING docs
Added updated instructions for building on Linux and added a script to auto-download the correct bazel version and add it to local venv path.