Don't copy the program name in argv_process_no_env #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
programname
branch
from
901464c
to
50eb4ab
Compare
|
You sure that it doesn't change? |
to save the memory and make argv_program to const Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I1fef3418f103664a0c3fde02e490eba834539f49
xiaoxiang781216
force-pushed
the
programname
branch
from
50eb4ab
to
6ad7857
Compare
I add const to argv_program to avoid modify(e.g. strcpy) argv_program internally. If you mean caller modify argv[0] directly, I suppose that no people is so crazy:). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to save the memory