Remove the static buffer(options) inside process_environ #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it isn't needed anymore after commit: commit 37daa70 Author: Xiang Xiao <xiaoxiang@xiaomi.com> Date: Sun Apr 18 13:05:24 2021 -0500 Remove 1KB stack buffer from _dmalloc_environ_process (j256#74) to save the stack space and move the NULL check to process_environ to avoid the duplication Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I62fb4acfd2602d7c34651ae2e6d1e35d3da2bdc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it isn't needed anymore after commit:
and move the NULL check to process_environ to avoid the duplication