-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically put java project dependencies on the sourcepath; #12 #22
Conversation
+1 great idea |
|
||
// Project depedencies. | ||
if (project.j2objcConfig.appendProjectDependenciesToSourcepath) { | ||
def depSourcePaths = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 4 spaces instead of 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brunobowden fixed in new squashed commit. note however that this whole file has mixed tabs + spaces, which we should fix in a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in new squashed commit 395f7be
3b23afa
to
4cbd07e
Compare
…-contrib#12 Set appendProjectDependenciesToSourcepath = true to add the java srcDirs of all project dependencies to the sourcepath for j2objc.
4cbd07e
to
395f7be
Compare
Thanks @advayDev1. One thought, I haven't got a project with dependencies yet. Would it be sensible in the future to have this |
Yes in the future depending on how you version this code - it seems you On Mon, Apr 6, 2015, 5:55 PM Bruno Bowden notifications@github.com wrote:
|
If you use jar dependencies in your project they should only be added to the |
@brunobowden You can merge the pull request. |
Automatically put java project dependencies on the sourcepath; #12
Set appendProjectDependenciesToSourcepath = true to add the java srcDirs of all project dependencies to the sourcepath for j2objc.