Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically put java project dependencies on the sourcepath; #12 #22

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

advayDev1
Copy link
Contributor

Set appendProjectDependenciesToSourcepath = true to add the java srcDirs of all project dependencies to the sourcepath for j2objc.

@advayDev1 advayDev1 mentioned this pull request Apr 6, 2015
@confile
Copy link
Contributor

confile commented Apr 6, 2015

+1 great idea


// Project depedencies.
if (project.j2objcConfig.appendProjectDependenciesToSourcepath) {
def depSourcePaths = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 spaces instead of 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunobowden fixed in new squashed commit. note however that this whole file has mixed tabs + spaces, which we should fix in a separate commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in new squashed commit 395f7be

…-contrib#12

Set appendProjectDependenciesToSourcepath = true to add the java srcDirs of all project dependencies to the sourcepath for j2objc.
@brunobowden
Copy link
Contributor

Thanks @advayDev1.

One thought, I haven't got a project with dependencies yet. Would it be sensible in the future to have this true by future?

@advayDev1
Copy link
Contributor Author

Yes in the future depending on how you version this code - it seems you
don't have release tags yet. Also I'm trying to figure out how to do this
for all dependencies automatically, after that it should be default true.

On Mon, Apr 6, 2015, 5:55 PM Bruno Bowden notifications@github.com wrote:

Thanks @advayDev1 https://github.com/advayDev1.

One thought, I haven't got a project with dependencies yet. Would it be
sensible in the future to have this true by future?


Reply to this email directly or view it on GitHub
https://github.com/brunobowden/j2objc-gradle/pull/22#issuecomment-90299420
.

@confile
Copy link
Contributor

confile commented Apr 7, 2015

If you use jar dependencies in your project they should only be added to the sourcepath if they are source jars.

@confile
Copy link
Contributor

confile commented Apr 8, 2015

@brunobowden You can merge the pull request.

brunobowden added a commit that referenced this pull request Apr 8, 2015
Automatically put java project dependencies on the sourcepath; #12
@brunobowden brunobowden merged commit b8b6c4c into j2objc-contrib:master Apr 8, 2015
@advayDev1 advayDev1 deleted the advayDev1-projectDep branch April 9, 2015 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants