Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument order in call to join(). #357

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Fix argument order in call to join(). #357

merged 2 commits into from
Apr 28, 2020

Conversation

CatalinFrancu
Copy link
Contributor

No description provided.

@szepeviktor
Copy link

szepeviktor commented Jan 29, 2020

Included in #351

@henryruhs
Copy link

henryruhs commented Apr 25, 2020

@szepeviktor I closed that PR - seems to be too much changes for the maintainer
@j4mie Please merge that PR and release bugfix - thanks

@treffynnon
Copy link
Collaborator

@redaxmedia I am unclear what you want to have merged here

@henryruhs
Copy link

henryruhs commented Apr 25, 2020

@treffynnon This pull request?

It removes one deprecation warning by switching glue and array. Using PHPUnit with convertWarningsToExceptions="true" failes under PHP 7.4 otherwise.

@treffynnon treffynnon changed the base branch from master to develop April 28, 2020 20:49
@treffynnon treffynnon merged commit bacd47d into j4mie:develop Apr 28, 2020
@treffynnon
Copy link
Collaborator

treffynnon commented Apr 29, 2020

Thank you @CatalinFrancu and @redaxmedia I have now merged the pull request and tagged release 1.5.7.

@redaxmedia I have also slightly updated the readme to further clarify the feature complete message.


Feature [/API] complete

Idiorm is now considered to be feature complete as of version 1.5.0. Whilst it will continue to be maintained with bug fixes there will be no further new features added from this point on. [This means that if a pull request makes breaking changes to the API or requires anything other than a patch version bump of the library then it will not be merged.]

Please do not submit feature requests [or API breaking changes] as they will be closed without ceremony.


@CatalinFrancu CatalinFrancu deleted the patch-1 branch April 29, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants