Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation #284

Open
LeBress opened this issue Jul 6, 2021 · 13 comments
Open

Translation #284

LeBress opened this issue Jul 6, 2021 · 13 comments

Comments

@LeBress
Copy link

LeBress commented Jul 6, 2021

Hello,
When do you manage the language translations. I would like to translate it into French.

@Willmac16
Copy link
Collaborator

@LeBress since we haven't done any translations yet it may take a few days to get things ready for you. Once we do, you would be working with a text document (you could even do it on GitHub) and giving a French translation for each snippet of English.

@Willmac16
Copy link
Collaborator

@LeBress if you wanted to get started you could work on this file. You will need to select the translations branch at the top left.
image

Some of the snippets are not appearing correctly in the UI for me, but I think most of what you would need to work with is there.

Let me know if you have questions.

@LeBress
Copy link
Author

LeBress commented Jul 10, 2021 via email

@Willmac16
Copy link
Collaborator

@LeBress I can't seem to see any translation. Could you try sending it via GitHub on the web rather than by email?

@LeBress
Copy link
Author

LeBress commented Jul 12, 2021

Hello,
Here are the messages.po and messages.mo files translated into French. Can you test them to see the different display issues. Thank you.
@ +

messages.zip

@Willmac16
Copy link
Collaborator

image
image
image

cmd widget settings needs some fixes probably on my part
image

image

@LeBress
Copy link
Author

LeBress commented Jul 12, 2021

Thanks for the test, but there are display problems in other windows. Like you, I will take screenshots that will be more precise and more explicit about the problems.
@ +

@Willmac16
Copy link
Collaborator

I am getting this strange formatting
image

I think most of the issues will be in the Info sections of individual widget's settings.

@Willmac16
Copy link
Collaborator

@LeBress Check out the latest commit on the translations branch. I think I got it all working, however, I had to use a somewhat hacky workaround. I tweaked a few of the translations to match what the French language pack I installed went with, but I will leave the translating up to you.

For anyone who wants to work in the Jinja files, Babel only seems to pick up English strings from {{ _('English to translate here') }} style strings but some finicky strings would only translate with data-bind="text: gettext('English to translate here')". The strange behavior mostly appeared with the long text following Info or Warning. There is a hidden section called testSection that has the bracket version of the string while gettext is used inside the settings sub-modal.

@LeBress
Copy link
Author

LeBress commented Jul 15, 2021

Hello,

Thank you for all the changes you have made so that the French language is better integrated into your plug-in.
Here are the updated message files.

messages.zip

If I may, here are screenshots of a few issues still present.

I can't translate because I don't understand this sentence

Annomalies

Annomalies 2

Annomalies 3

When the mouse cursor is over the text, this is what is displayed

Annomalies 4

Annomalies 5

When the mouse cursor is on the value here is what is displayed. This is valid for all icons

Why specify that it is the nozzle and not specify that it is the bed in the other graphic

Annomalies 6

Thank you for taking all my comments into account. You did a great job.

@ +

@Willmac16
Copy link
Collaborator

@LeBress "Disable nonce for OctoPrint Webcam". Nonce is a one time use random bit of text stuck onto the end of the webcam url to ensure the image is current and not from a while ago. Since Dashboard has its own option to do multiple cameras this setting refers to the webcam configured in the octoprint webcam and Timelapse tab not the multiple webcams configured in Dashboard settings. I'm not sure if there is a good translation for nonce (it's the only term I know of that is used in reference to the string).

@Willmac16
Copy link
Collaborator

@LeBress I'll get working on the not yet translated titles and let you know when I'm ready for you to translate them.

I believe the original rational for the nozzle label was for MultiExtruder setups so it would say Tool 1 Tool 2 etc., but it shouldn't be difficult to add the labels in for the other gauges.

Were there any other difficult to translate snippets?

@Willmac16
Copy link
Collaborator

@LeBress I found ~30 description strings that I had missed since they weren't formatted how I expected. They are ready to be translated now.

And I added description text to the other temp gauges. (It may still need some tweaking since the text is a bit doubled up).
image

I'll try to deal with the fan "Off" string once I have merged the translation code with the actively developed code (since things have changed for the fan stuff on the backend).

@j7126 j7126 pinned this issue Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants