Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this maintained anymore? #19

Closed
Maistho opened this issue Feb 25, 2016 · 8 comments
Closed

Is this maintained anymore? #19

Maistho opened this issue Feb 25, 2016 · 8 comments

Comments

@Maistho
Copy link

Maistho commented Feb 25, 2016

This seems like it's not being maintained anymore, the latest commit was in October (and it actually broke the api).
Would it be possible for me to take over maintenance?
ping @jBenes @sidferreira

I would be happy to take over the repository, and will at least try to keep my fork updated for now.

For all the current Pull Requests:

@andre-huehn
Copy link

I would be happy if you could take over.

Do you think there is a better way to find out if image url is a local
image, so that we do not even try to cache it?

Andre

On Thu, Feb 25, 2016 at 3:59 AM, Gustav Bylund notifications@github.com
wrote:

This seems like it's not being maintained anymore, the latest commit was
in October (and it actually broke the api).
Would it be possible for me to take over maintenance?
ping @jBenes https://github.com/jBenes @sidferreira
https://github.com/SidFerreira

I would be happy to take over the repository, and will at least try to
keep my fork https://github.com/maistho/angular-imgcache.js updated for
now.

For all the current Pull Requests:


Reply to this email directly or view it on GitHub
#19.

@Maistho
Copy link
Author

Maistho commented Feb 25, 2016

I'm not sure, but for my use case it is better to just handle the failure. Sometimes it will fail to get the image because of XHR restrictions or some other thing, and then it is better to just fallback imo. Maybe one can do both?

@jBenes
Copy link
Owner

jBenes commented Feb 25, 2016

@Maistho Hi, thanks.
Sorry, I don't really have time to maintain it. I will check repository settings during the weekend and try to share it with you.

@sidferreira
Copy link
Contributor

@Maistho Go for it :)
I've been using a different approach on my projects now, but I'll share it cause maybe it helps improving it.

@Maistho
Copy link
Author

Maistho commented Mar 3, 2016

@Maistho
Copy link
Author

Maistho commented Mar 14, 2016

ping @jBenes
Not intending to bug you more than I need to (I know how it is to be busy), but granting push access or transferring the repository are both "less than 5 minutes" kind of actions. 😃

@gslender
Copy link

I had all sorts of problems and until I changed over to the maintained version by @Maistho it wasn't working. @jBenes if you aren't going to maintain it, please hand it over or tell @chrisben you aren't maintaining a working angular solution.

@Maistho
Copy link
Author

Maistho commented Apr 1, 2016

Hi,

I've updated imgcache.js to point to my fork
chrisben/imgcache.js#163

And also updated the bower registry.
bower/registry#184

Just installing it with bower should now give you the updated version! 🎉

If you have any problems, please open an issue at
https://github.com/maistho/angular-imgcache.js/issues

@Maistho Maistho closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants