MatParamTexture: duplicate variables, missing javadoc, exceptions #2243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues with the
MatParamTexture
class:texture
variable is redundant as it's already stored in the inheritedvalue
variable. This PR removes the unnecessary texture field.setValue
methods regarding null values differed. This PR modifiessetValue
to allow null values, aligning it with the behavior ofsetTextureValue
and the superclass'ssetValue
.Key improvements:
Overall, this PR enhances the MatParamTexture class by streamlining the code, providing proper documentation, and ensuring consistent behavior.
--Edit:
Instead of overriding
setValue
inMatParamTexture
, we can leverage the existing behavior in the superclass. The superclass method likely performs type and value checking, making an override unnecessary in this case (see #1797).