Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit numerical instability handling #145 #147

Merged
merged 12 commits into from
Sep 3, 2023

Conversation

jacanchaplais
Copy link
Owner

  • replaced phi where pt is low with nan (and raised NumericalStabilityWarning)
  • corrected _root_diff_two_squares() for case when both inputs are negative (in turn fixing mass_t)
  • rapidity division by zero explicitly handled, converting nan values into appropriately signed infinities

@jacanchaplais jacanchaplais added the enhancement New feature or request label Sep 1, 2023
@jacanchaplais jacanchaplais added this to the 0.3.1 milestone Sep 1, 2023
@jacanchaplais jacanchaplais self-assigned this Sep 1, 2023
@jacanchaplais jacanchaplais linked an issue Sep 1, 2023 that may be closed by this pull request
@jacanchaplais jacanchaplais merged commit 7c4eac6 into main Sep 3, 2023
8 checks passed
@jacanchaplais jacanchaplais deleted the feature/unstable-145 branch September 3, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Handle numerically unstable calculations
1 participant