Update the module to work with PHP 7.2 and Webform #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few sections of the UX module are not working with PHP 7.2.
Exposed Filters of checkboxes are confused if no checkboxes are set. The default is no longer the "All" option, but an empty Array of options. PHP 7.2 throws a nasty error because it cannot convert a string to an empty array.
Also, the Webform module is starting to use a
Drupal\Core\Template\Attributeclass to manage attributes on some forms. UX Form now exports those to a more basic Array also accepted by the render system and adds a few classes as desired.