Fix build for Arch #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes a compilation error that (for some reason) seems to be local to Arch distros. I think it has something to do with the current version of clang in the Arch community repos.
|
Well, the code auto-formatter made a bunch of changes that are not related to this PR too. That's what I get for pushing changes directly to main earlier. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #53.
For some reason, initializing combobox_options with braces led to a compilation error on Arch-based distributions. I think this might have something to do with the version of clang Arch uses, but I am not sure. Regardless, using parenthesis to construct the field fixed the issue.
I also found and fixed another Arch specific error when testing. It seems
pscan sometimes return an underscore for "context" when a process is unconfined. This was leading to an issue when using regular exceptions to parse its output. I fixed the issue and made the regex parsing more resilient to exceptions.