Make backtrace support depends on execinfo.h existence #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -483,6 +483,12 @@ def configure(conf): | |||
| defines=['_GNU_SOURCE'], | |||
| mandatory=False) | |||
|
|
|||
| # Check for backtrace support | |||
| conf.check_cc( | |||
There was a problem hiding this comment.
Do not use check_cc use check instead. See https://github.com/waf-project/waf/blob/master/waflib/Tools/c_config.py#L762
|
See comment on the |
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 17, 2016
This change adds a patch checking for the presence of execinfo.h header and enabling the backtrace support depending on the check result. Fixes: http://autobuild.buildroot.org/results/415/415e2100dc59d35e58646c07f7cdccabecdda966/ http://autobuild.buildroot.org/results/43c/43ca1b103434ae582fdf93cb5912b311960f303b/ http://autobuild.buildroot.org/results/391/391e71a988250ea66ec4dbee6f60fdce9eaf2766/ ... Adapted from the PR: jackaudio/jack2#206 Signed-off-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
tSed
force-pushed
the
fix-build-when-execinfo.b-is-not-available
branch
from
a8ee928
to
198c631
Compare
| @@ -483,6 +483,13 @@ def configure(conf): | |||
| defines=['_GNU_SOURCE'], | |||
| mandatory=False) | |||
|
|
|||
| # Check for backtrace support | |||
| conf.check( | |||
| compiler='c', | |||
There was a problem hiding this comment.
Why compiler='c'? Waf should be able to guess that. See https://github.com/waf-project/waf/blob/master/waflib/Tools/c_config.py#L472
There was a problem hiding this comment.
Well, I'm not familiar with waf...
|
I'm glad you changed from |
In some C-libraries (like uclibc), backtrace support is optional, so the execinfo.h may not exist. This change adds the check for execinfo.h header and conditionaly enable backtrace support. This issue has been triggered by Buildroot farms: http://autobuild.buildroot.org/results/391/391e71a988250ea66ec4dbee6f60fdce9eaf2766/build-end.log Signed-off-by: Samuel Martin <s.martin49@gmail.com>
tSed
force-pushed
the
fix-build-when-execinfo.b-is-not-available
branch
from
198c631
to
8ac6bf1
Compare
|
ping? |
adiknoth
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some C-libraries (like uclibc), backtrace support is optional, so the
execinfo.h may not exist.
This change adds the check for execinfo.h header and conditionaly enable
backtrace support.
This issue has been triggered by Buildroot farms:
http://autobuild.buildroot.org/results/391/391e71a988250ea66ec4dbee6f60fdce9eaf2766/build-end.log
Signed-off-by: Samuel Martin s.martin49@gmail.com