-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIT alsa improvement backports #949
Open
amiartus
wants to merge
12
commits into
jackaudio:master
Choose a base branch
from
amiartus:adit-alsa-improvement-backports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
294bcf7
alsa_driver: Use float to S32 conversion if requested
6b65394
alsa_driver: Extract snd_pcm_start/poll_descriptors/avail_update
7ae0005
alsa_driver: remove unused functions
07946eb
alsa_driver: remove header declaration of local function
amiartus 26aa0d6
alsa_driver: extract alsa_driver_open functionality to a function
amiartus a224479
alsa_driver: extract alsa_driver_set_sample_bytes functionality to a …
amiartus cca8e8a
alsa_driver: extract alsa_driver_check_fromat to a separate function
amiartus 4579cff
alsa_driver: extract alsa_driver_prepare to a separate function
amiartus 55d76ac
alsa_driver: extract alsa_driver_get_status to a separate function
amiartus e5a17e8
alsa_driver: compute silence_frames is only neccessary once
amiartus d836c55
alsa_driver: use err variable, useful for debugging and readability
amiartus 08c5c42
alsa_driver: refactor struct member position for readability
amiartus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What purpose does it serve to add an unused function parameter? If the idea is to make function calls somehow more uniform, then I think applying such an unwavering ideal to even these sort of internal static functions crosses the line from reasonable to dogmatic.
Is there something I'm not seeing here? Does adding
bool is_capture
actually lay groundwork for an actually useful change down the line? How?Also: this is literally a wrapper around calling a function with the same signature. It simply adds a static function effectively to rename an ALSA API function. In my opinion the negative outcome of adding more LOC weighs more than whatever the subjective benefit of this is supposed to be.
But again, if I'm missing some bigger picture, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is a groundwork for additional features. iirc the general feature is adding multiple playback/capture devices that can be started in alsa_driver. this was done some years ago and I still have the patches laying around somewhere on my drive.
it didnt get merged in previous PR due to large amount of changes, so I split in and this is one of the PRs that is a pre-requisite for that work.
I think its this one: https://github.com/miartad/jack2/commits/ami-alsa-multidev/