-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more vector stuff and make sure it uses immutable vectors #133
Conversation
These should be provided by the |
Oh yeah I forgot. |
(define (vector-ref-lens i) | ||
(make-lens | ||
(vector-ref _ i) | ||
(vector-set _ i _))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my comment on the string-ref-lens, I think it would be simpler to build this atop list-ref-lens
instead of implementing vector-set
.
What do you think? |
Merging the other one I think triggered the need for a rebase of this one |
Ok I just rebased. |
add more vector stuff and make sure it uses immutable vectors
closes #120
closes #125
closes #127