Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bb test files #46

Merged
merged 7 commits into from
Jun 30, 2024
Merged

Add bb test files #46

merged 7 commits into from
Jun 30, 2024

Conversation

nvictus
Copy link
Collaborator

@nvictus nvictus commented Jun 29, 2024

No description provided.

Copy link
Owner

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bigBedExample file is already in the pybigtools test data directory - should move instead of adding a new file.

What is the other file for?

@@ -245,6 +248,18 @@ def test_zoom_records(bw, bb):
assert pytest.raises(KeyError, bb.zoom_records, 3911, "chr11")


# def test_values_no_end(bw, bb):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently failing (panic). Was gonna address in a separate PR.

@nvictus
Copy link
Collaborator Author

nvictus commented Jun 29, 2024

What is the other file for?

An example bigBed file with a custom autoSql schema (genePred).

@jackh726
Copy link
Owner

I've identified the issue with the added test

@jackh726
Copy link
Owner

Okay, both issues are fixed - can you rebase?

@jackh726 jackh726 merged commit fbe1ddb into jackh726:master Jun 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants