-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bb test files #46
Conversation
3a0dc72
to
5c2b5ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bigBedExample file is already in the pybigtools test data directory - should move instead of adding a new file.
What is the other file for?
pybigtools/tests/test_api.py
Outdated
@@ -245,6 +248,18 @@ def test_zoom_records(bw, bb): | |||
assert pytest.raises(KeyError, bb.zoom_records, 3911, "chr11") | |||
|
|||
|
|||
# def test_values_no_end(bw, bb): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently failing (panic). Was gonna address in a separate PR.
An example bigBed file with a custom autoSql schema (genePred). |
I've identified the issue with the added test |
Okay, both issues are fixed - can you rebase? |
241017e
to
c92a78c
Compare
No description provided.