Fix wallet creation bugs related to crypto #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix encryption when using PyCrypto or SlowAES * use os.urandom wherever cryptographically secure rnd #s are required
jackjack-jj
added a commit
that referenced
this pull request
Sep 8, 2014
Fix wallet creation bugs related to crypto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet creation (e.g. during recovery or merge) when using PyCrypto (the default) or SlowAES wasn't performing the encryption correctly resulting in a wallet that couldn't be unlocked.
Also, switched to using os.urandom wherever cryptographically secure random numbers are required as per the Python random documentation which calls the default random module "completely unsuitable for cryptographic purposes."