Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Fortran subroutines defined in interface blocks #231

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

billsacks
Copy link
Contributor

This finds generic procedures defined like this:

  interface endrun
     module procedure endrun_vanilla
     module procedure endrun_globalindex
  end interface

(where you're looking for the definition of 'endrun').

Since there is no instance of subroutine endrun (...) (only subroutine endrun_vanilla (...) and subroutine endrun_globalindex (...)), this change is needed in order to find the place where endrun is defined.

This finds generic procedures defined like this:

  interface endrun
     module procedure endrun_vanilla
     module procedure endrun_globalindex
  end interface

(where you're looking for the definition of 'endrun').
@billsacks
Copy link
Contributor Author

Thanks a lot for this very useful package!

Some caveats:

  1. I wasn't able to get cask to work, so wasn't able to run the tests on this change

  2. I have only been using this package for a day, and this change for a few minutes, so it's possible that this change does the wrong thing in some situations. If you prefer to wait to merge this until I have more experience with the change, that's fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.063% when pulling 39f9b28 on billsacks:fortran_interface into 9e79b74 on jacktasia:master.

@jacktasia jacktasia self-requested a review September 28, 2018 22:17
Copy link
Owner

@jacktasia jacktasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and kind words!

@jacktasia jacktasia merged commit 76f7089 into jacktasia:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants