fix: properly remove observed element from InterseciontObserverShared when component destroyed

jacob-8 · jacob-8 · commit 51d83817a967 · 2024-01-10T15:34:44.000+08:00
diff --git a/src/lib/functions/IntersectionObserverShared.svelte b/src/lib/functions/IntersectionObserverShared.svelte
@@ -73,7 +73,7 @@
       };
       add(childElement, fired_when_interesecting_changes);
 
-      return () => remove(container);
+      return () => remove(childElement);
     }
 
     function handler() {

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@`
`73`	`73`	`};`
`74`	`74`	`add(childElement, fired_when_interesecting_changes);`
`75`	`75`
`76`		`- return () => remove(container);`
	`76`	`+ return () => remove(childElement);`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`function handler() {`