Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't dstep exit with status code when there is some kind of error? #59

Closed
ciechowoj opened this issue Apr 7, 2016 · 1 comment
Closed

Shouldn't dstep exit with status code when there is some kind of error? #59

ciechowoj opened this issue Apr 7, 2016 · 1 comment

Comments

@ciechowoj
Copy link
Contributor

Currently dstep always returns 0 exit code, even on the failure (wrong input file/wrong command arguments). I believe it would be better, if it returns something other (e.g. 1) when there is an error. I would make dstep easier to integrate with some command line tools (and make testing easier).
@jacob-carlborg
Copy link
Owner

Absolutely. It should exit with a non-zero status code if an exception has been thrown. Although, I'm not sure if an exception is thrown in all the right places.

ciechowoj added a commit to ciechowoj/dstep that referenced this issue Jul 30, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
644174c 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
@ciechowoj ciechowoj mentioned this issue Jul 30, 2016
Merged
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Jul 30, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
288e1a6 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
@ciechowoj ciechowoj mentioned this issue Aug 3, 2016
Merged
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 6, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
4010fa1 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 8, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
2086f79 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 8, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
62cd13d 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 8, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
eefa6d3 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 8, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
40acb52 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 8, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
560c104 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 8, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
d67ffc1 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
ciechowoj added a commit to ciechowoj/dstep that referenced this issue Aug 9, 2016
@ciechowoj
Fix jacob-carlborg#59: Shouldn't dstep exit with status code when the…
851ebbc 
…re is some kind of error?

Fix jacob-carlborg#28: Crashes if fed nonexistent header.
jacob-carlborg added a commit that referenced this issue Aug 10, 2016
@jacob-carlborg
Merge pull request #81 from ciechowoj/issue_28
32e0cd7 
Fix #59 and #28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacob-carlborg @ciechowoj