Refactor away from generics #19

jacobrosenthal · 2020-05-31T00:07:23Z

This seems to be working well, so its time for me to clean up my mess.

My big issues are

clean up the docs
cleanup my generic mess. Thats the major change here.
How does anyone feel about the singular ReadWrite trait to fix remove hidapi as only using it for the trait #6, which enables the use of impl trait. Am I missing a way or reason to split these out as separate Read and Write?
and for no good reason I always wanted it to be no_std no alloc able..Thoughts on a clean api supporting both vec and heapless::vec ala Intrusive #2 ?

jacobrosenthal · 2020-06-06T02:08:54Z

Closes #6 as well

jacobrosenthal force-pushed the cleanup branch from 8909f2d to 97e541c Compare June 2, 2020 18:12

jacobrosenthal mentioned this pull request Jun 3, 2020

Windows support #20

Merged

jacobrosenthal force-pushed the cleanup branch from 97e541c to c87127d Compare June 3, 2020 16:19

jacobrosenthal marked this pull request as draft June 4, 2020 18:36

jacobrosenthal force-pushed the cleanup branch from c87127d to b68af65 Compare June 5, 2020 06:28

hf2: hidapi as optional, work on ReadWrite trait

a05ad0d

jacobrosenthal force-pushed the cleanup branch from eb50949 to ee17113 Compare June 5, 2020 21:04

remove silly generics interface

cd791d0

jacobrosenthal force-pushed the cleanup branch from ee17113 to cd791d0 Compare June 6, 2020 02:06

jacobrosenthal changed the title ~~Towards 1.0~~ Refactor away from generics Jun 6, 2020

jacobrosenthal marked this pull request as ready for review June 6, 2020 02:08

jacobrosenthal merged commit 4127d13 into master Jun 6, 2020

Provide feedback