#97 #105 Study group form #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ONourry
requested review from
jacobrs,
simon-bourque,
MartinSpasov and
samantha-kerr
|
Seems like travis is mad about something. Let me look at it first. |
|
Alright the build is passing now. I'm not sure why that one line redirecting the url changed the return value but it did so I removed it. |
|
I get this error message whenever I try to add a study group Does anyone else get this error? |
|
I'm not getting any error. What steps are you taking exactly? |
|
|
its weird because I don't see how addUser is being called? |
|
perhaps add user is being called instead of addUserStudyGroups |
simon-bourque
previously requested changes
Mar 8, 2017
client/modules/User/UserActions.js
Outdated
|
|
||
| export function createStudyGroupRequest(studyGroup) { | ||
| return (dispatch) => { | ||
| return callApi('users', 'post', { |
There was a problem hiding this comment.
should be 'studyGroups' and not 'users' as discussed on slack
|
alright ima test it |
simon-bourque
requested changes
Mar 8, 2017
simon-bourque
approved these changes
Mar 8, 2017
|
Approving for sprint 3, we will make a separate issue for what was discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Created the study group form
2- Added the necessary routing for the new form
3- Added a navbar button to allow the user to create study groups
3- Modified the registration form to prevent page refresh (makes the website faster)
The validation for the study group only requires the user to have every field filled out. No specific format is required for the group name, teacher name, course tag or description.