Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#127, #131 Add members #132

Merged
merged 5 commits into from
Apr 5, 2017
Merged

#127, #131 Add members #132

merged 5 commits into from
Apr 5, 2017

Conversation

jacobrs
Copy link
Owner

@jacobrs jacobrs commented Apr 5, 2017

  • Style changes to dashboard
  • Added a modal to add new users to chat
  • Added mini chat menu
  • 👍

@jacobrs jacobrs added this to the Sprint 5 milestone Apr 5, 2017
@jacobrs jacobrs self-assigned this Apr 5, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 88.0% when pulling 90ced48 on add_members into ecf7fea on master.

simon-bourque
simon-bourque approved these changes Apr 5, 2017
View reviewed changes
Copy link
Collaborator

@simon-bourque simon-bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested front end, everything looks good!

@simon-bourque
Copy link
Collaborator

simon-bourque commented Apr 5, 2017 •
edited
Loading

Oof except one little thing on Firefox the row with the textarea and send button for the chat extends off screen vertically and is noticeably bigger then the version on chrome but that is just a styling thing and I don't think it is much of an issue at the moment

Philippe229
Philippe229 approved these changes Apr 5, 2017
View reviewed changes
Copy link
Collaborator

@Philippe229 Philippe229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back end code is good. Tested locally with no errors

@jacobrs jacobrs merged commit 90e3682 into master Apr 5, 2017
@jacobrs jacobrs deleted the add_members branch April 5, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-bourque simon-bourque simon-bourque approved these changes

@Philippe229 Philippe229 Philippe229 approved these changes

@pbgnz pbgnz Awaiting requested review from pbgnz

Assignees

@jacobrs jacobrs

Labels
backend frontend urgent userstory
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobrs @coveralls @simon-bourque @Philippe229