Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGoldenFiles fails with Go 1.5 tip #28

Closed
mwhudson opened this issue Jul 27, 2015 · 0 comments
Closed

TestGoldenFiles fails with Go 1.5 tip #28

mwhudson opened this issue Jul 27, 2015 · 0 comments

Comments

@mwhudson
Copy link

mwhudson@glamdring:ogletest$ go version
go version devel +0acecb7 Wed Jul 22 20:27:24 2015 +0000 linux/amd64
mwhudson@glamdring:ogletest$ go test ./...
--- FAIL: TestGoldenFiles (5.32s)
    integration_test.go:262: Output for test case panicking doesn't match golden file.
FAIL
FAIL    github.com/jacobsa/ogletest 5.322s
ok      github.com/jacobsa/ogletest/srcutil 0.001s
?       github.com/jacobsa/ogletest/test_cases  [no test files]
?       github.com/jacobsa/ogletest/test_cases/mock_image   [no test files]
mwhudson@glamdring:ogletest$ go version
go version devel +0acecb7 Wed Jul 22 20:27:24 2015 +0000 linux/amd64
mwhudson@glamdring:ogletest$ go test -v github.com/jacobsa/ogletest
=== RUN   TestNoCurrentTest
--- PASS: TestNoCurrentTest (0.00s)
=== RUN   TestNoFailure
--- PASS: TestNoFailure (0.00s)
=== RUN   TestInvalidFormatString
--- PASS: TestInvalidFormatString (0.00s)
=== RUN   TestNoMatchWithoutErrorText
--- PASS: TestNoMatchWithoutErrorText (0.00s)
=== RUN   TestNoMatchWithErrorTExt
--- PASS: TestNoMatchWithErrorTExt (0.00s)
=== RUN   TestFailureWithUserMessage
--- PASS: TestFailureWithUserMessage (0.00s)
=== RUN   TestAdditionalFailure
--- PASS: TestAdditionalFailure (0.00s)
=== RUN   TestGoldenFiles
--- FAIL: TestGoldenFiles (4.16s)
    integration_test.go:262: Output for test case panicking doesn't match golden file.
FAIL
exit status 1
FAIL    github.com/jacobsa/ogletest 4.165s

I guess the details of what is printed after a panic has changed, I haven't actually looked.

onlyjob added a commit to onlyjob/ogletest that referenced this issue Feb 29, 2016
…cobsa#28).

Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>
jacobsa added a commit that referenced this issue Mar 2, 2016
Make them slightly more lenient for next time.

For #28 and #29.
@jacobsa jacobsa closed this as completed Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants