You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the root config options, if a key is specified in the config file that is not specified in the code's config we ignore it. This allows subcommands the ability to specify config file options. One of the side effects is that a bad config file key name will not be caught and if the user isn't notified somehow then it could potentially cause issues, with things like connections, that would be difficult to troubleshoot.
for example:
TLS: http://localhost:42114/cert
instead of
tls: http://localhost:42114/cert
This example would start the tinklet with tls: false, which is not what the user intended. Currently, there would be no notification to the end-user that this config file value was not used.
Possible solutions:
update the tls config file key to be more single purpose. so make separate keys for true/false, HTTP location, and file location.
add some validation to the root command to catch situations like this
investigate the ff library more for a possible solution
The text was updated successfully, but these errors were encountered:
For the root config options, if a key is specified in the config file that is not specified in the code's config we ignore it. This allows subcommands the ability to specify config file options. One of the side effects is that a bad config file key name will not be caught and if the user isn't notified somehow then it could potentially cause issues, with things like connections, that would be difficult to troubleshoot.
for example:
instead of
This example would start the tinklet with
tls: false
, which is not what the user intended. Currently, there would be no notification to the end-user that this config file value was not used.Possible solutions:
tls
config file key to be more single purpose. so make separate keys for true/false, HTTP location, and file location.The text was updated successfully, but these errors were encountered: