Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Larger fonts + bar rendering #28

Closed
wants to merge 1 commit into from

Conversation

renataogarcia
Copy link

The latest EclEmma version (2.2.0) renders the bar as shown below on my computer running Linux/GTK.

GTK-Glitch

The bars become very large and there is also an small glitch that the bars will bleed into the header.

This also happens on Windows when using larger fonts as shown below:
Win-Lrg

Compared to the default font size on Windows:
Win-Sml

This patch renders the bar height proportionally to the font height which gives better results. It should also fix the issue with the table header and footer on GTK.

This is how is it rendered on GTK with the patch:
GTK-jacoco-patch

Additionally the patch allows the user to choose their preferred look of the bar. I provided two implementations aligned to the EclEmma schema colors. Here is a preview:

GTK-eclemma-patch

@marchof
Copy link
Member

marchof commented Dec 7, 2012

Thanks für your contribution! The change is quite big and I think it needs to be discussed whether we want to maintain different bar implementations.

But the scaling issue should be fixed. Could you please provide a smaller change that just fixes this issue?

Closing this one.

@marchof marchof closed this Dec 7, 2012
@renataogarcia
Copy link
Author

I can rework this patch based on the previous code, but I'd rather see this functionality implemented.

I understand your maintenance concern but the new code is quite simple in fact. Most of the changes are related to the preferences page which is very trivial code and most of the bar rendering code is shared amongst the implementations.

I personally like the EclEmma style better the but I also see value in using the same style as the JaCoCo reports. In the end this is a matter of taste, so why not let the users choose their preferred style?

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants