Skip to content

Conversation

jakobbraun
Copy link
Contributor

jacoco-maven-plugin does not define a project URL in the pom file. In that case, maven inherits the value of the parent pom and appends the artifact id (see maven documentation).
By that maven resolves the URL to http://jacoco-maven-plugin/, which does not exist.

This PR fixes that issue by adding an explicit URL to the project.

jacoco-maven-plugin does not define a project URL in the pom file. In that case, maven inherits the value of the parent pom and appends the artifact id (see maven documentation).
By that maven resolves the URL to http://jacoco-maven-plugin/, which does not exist.
@Godin
Copy link
Member

Godin commented Mar 24, 2021

@jakobbraun could you please clarify where this URL is visible by users?

@jakobbraun
Copy link
Contributor Author

@Godin sure.
In my case, it's visible using the Maven API. I'm using the maven API to generate a notice file that references all dependencies.
Accoring to the maven docs it's a "nice gesture for projects users, however, so that they know where the project lives."

@redcatbear
Copy link

Having this fix would be beneficial for us since we would love to have a correct list of project pages.
We want to properly acknowledge all OSS makers where we use their software as external dependencies. And part of that acknowledgement is to get the project URL right.

Please consider merging this PR.

@Godin Godin changed the title Added url to jacoco-maven-plugin Add url to jacoco-maven-plugin Apr 13, 2021
@Godin Godin merged commit 2eca2f2 into jacoco:master Apr 14, 2021
@Godin Godin added this to the 0.8.7 milestone Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants