Java 8: Failure with default methods in interfaces

[stevenschlansker]

Jacoco can fail on Java 8 classes, in this particular case one with a default method implementation on an interface:

Caused by: java.io.IOException: Error while analyzing class /Users/steven/.../DiscoveryClient.class.
    at org.jacoco.core.analysis.Analyzer.analyzerError(Analyzer.java:150)
    at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:144)
    at org.jacoco.core.analysis.Analyzer.analyzeAll(Analyzer.java:175)
    at org.jacoco.core.analysis.Analyzer.analyzeAll(Analyzer.java:208)
    at org.jacoco.maven.BundleCreator.createBundle(BundleCreator.java:78)
    at org.jacoco.maven.AbstractReportMojo.createReport(AbstractReportMojo.java:219)
    at org.jacoco.maven.AbstractReportMojo.executeReport(AbstractReportMojo.java:193)
    ... 22 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 3
    at org.jacoco.core.internal.analysis.MethodAnalyzer.addProbe(MethodAnalyzer.java:288)
    at org.jacoco.core.internal.analysis.MethodAnalyzer.visitInsnWithProbe(MethodAnalyzer.java:224)
    at org.jacoco.core.internal.flow.MethodProbesAdapter.visitInsn(MethodProbesAdapter.java:76)
    at org.objectweb.asm.tree.InsnNode.accept(InsnNode.java:80)
    at org.objectweb.asm.tree.InsnList.accept(InsnList.java:162)
    at org.objectweb.asm.tree.MethodNode.accept(MethodNode.java:815)
    at org.jacoco.core.internal.flow.ClassProbesAdapter$1.visitEnd(ClassProbesAdapter.java:145)
    at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1021)
    at org.objectweb.asm.ClassReader.accept(ClassReader.java:693)
    at org.objectweb.asm.ClassReader.accept(ClassReader.java:506)
    at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:107)
    at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:142)
    ... 27 more

asm does not support Java 8 until 5.0.1, additionally maybe Jacoco itself needs some fixups for Java 8.

[marchof]

@stevenschlansker Thanks for reporting this! JaCoCo 0.7.0 is based on ASM5 and is supposed to support Java 8.

However, the instrumenter assumes that a interface does contain at most one method () which does not hold true for Java 8 interfaces with default methods. Therefore a wrong probe array length is calculated which results in the ArrayIndexOutOfBoundsException you encountered. I will see how we can fix this for Java 8.

[stevenschlansker]

Awesome. In case it is helpful, here is the interface I am having trouble with:

public interface DiscoveryClient extends AnnouncementPublisher
{
    default Announcement findAnnouncement(ServiceLookup lookup, LookupHint... hints)
    {
        final List<Announcement> announcements = findAnnouncements(lookup, hints);
        return announcements.isEmpty() ? null : announcements.get(ThreadLocalRandom.current().nextInt(announcements.size()));
    }

    default List<Announcement> findAllAnnouncements()
    {
        return findAnnouncements(ServiceLookup.with());
    }

    List<Announcement> findAnnouncements(ServiceLookup lookup, LookupHint... hints);
}

[Godin]

@marchof in any case seems that we must upgrade to ASM 5.0.1 - see http://mail.ow2.org/wws/arc/asm/2014-03/msg00034.html

[marchof]

@Godin Fortunately only issue 317127 seems to affect us. Anyways, I upgraded to 5.0.1.

[saden1]

When should we expect a release with a fix?

[marchof]

I found a solution for the problem. Need to cleanup the code and add more tests. The release should be available within 1-2 weeks.