Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change quote to quote_plus and avoid double-escaping some problematic characters. #237

Merged
merged 1 commit into from
Mar 16, 2014

Conversation

cro
Copy link
Contributor

@cro cro commented Mar 6, 2014

References issue #236.

@jacquev6
Copy link
Member

Thank you (again) for your contribution! I'll fix the Travis build and publish a new version next week-end.

@jacquev6 jacquev6 self-assigned this Mar 12, 2014
@jacquev6 jacquev6 added this to the Version 1.25.0 milestone Mar 12, 2014
jacquev6 added a commit that referenced this pull request Mar 16, 2014
Parameters are encoded in Requester => simply remove urllib.quote
Path needs to be encoded => change to urllib.quote_plus as in #237
@jacquev6 jacquev6 merged commit 972a91e into PyGithub:master Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants